Re: [PATCH v14 01/16] test: add test cases for relative_path

From: Junio C Hamano <gitster@pobox.com>
Date: Jun 24, 2013, 19:01 UTC
Message-ID: <7vli5z8ha0.fsf@alter.siamese.dyndns.org>
In-Reply-To: <85c9aa4d05dba4320a7cc85eae7570e0f450e58e.1372087065.git.worldhello.net@gmail.com>

Jiang Xin <worldhello.net@gmail.com> writes:

Show 21 quoted lines

> diff --git a/test-path-utils.c b/test-path-utils.c
> index 0092cb..dcc530 100644
> --- a/test-path-utils.c
> +++ b/test-path-utils.c
> @@ -28,6 +28,19 @@ static int normalize_ceiling_entry(struct string_list_item *item, void *unused)
>  	return 1;
>  }
>  
> +static void normalize_argv_string(const char **var, const char *input)
> +{
> +	if (!strcmp(input, "<null>"))
> +		*var = NULL;
> +	else if (!strcmp(input, "<empty>"))
> +		*var = "";
> +	else
> +		*var = input;
> +
> +	if (*var && (**var == '<' || **var == '('))
> +		die("Bad value: %s\n", input);
> +}
> +

If you have to munge the input string like this anyway, perhaps you can work around the command line mangling done by Windows bash runtime, perhaps add something like:

	if (*input == '_')
        	input++;

and then protecting the path with the underscore, like so?

	relative_path _/a/b/c/	_/a/b/		c/

Wouldn't that let you avoid having to handle "POSIX" prereq for these paths?