Re: [PATCH v14 05/16] Refactor write_name_quoted_relative, remove unused params
- From
Junio C Hamano <gitster@pobox.com>
- Date
- Jun 24, 2013, 19:19 UTC
- Message-ID
- <7v8v1z8gfu.fsf@alter.siamese.dyndns.org>
- In-Reply-To
- <6e5f34b62ff6a7d6b379a5cabc07b849539fb08f.1372087065.git.worldhello.net@gmail.com>
Jiang Xin <worldhello.net@gmail.com> writes:
Show 9 quoted lines
> -static void write_name(const char* name, size_t len)
> +static void write_name(const char *name)
> {
> - write_name_quoted_relative(name, len, prefix, prefix_len, stdout,
> - line_terminator);
> +
> + /* turn off prefix, if run with "--full-name" */
> + write_name_quoted_relative(name, prefix_len ? prefix : NULL,
> + stdout, line_terminator);Hmmm....
Does this mean that ls-files has been broken in 03/16, because write_name_quoted_relative() was made to ignore prefix_len and measure the length of prefix with strlen(prefix), and this change fixes it?