git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH v2 0/3] Fix broken CI on newer github-actions runner image

From
Jiang Xin <worldhello.net@gmail.com>
Date
Nov 24, 2022, 11:23 UTC
Message-ID
<CANYiYbEbb4sgWtQRSEYJbzcAYTKDRpmVtL62HMR-QekhY_8-bQ@mail.gmail.com>
In-Reply-To
<4oonnq45-s269-sr8n-o5sr-n214593nps8s@tzk.qr>

On Thu, Nov 24, 2022 at 6:48 PM Johannes Schindelin <Johannes.Schindelin@gmx.de> wrote:

Show 62 quoted lines
>
> Hi,
>
> On Thu, 24 Nov 2022, Johannes Schindelin wrote:
>
> > To build even more confidence in the patch series, I will now start a full
> > run (which will take *a lot* of build minutes, unfortunately).
>
> And it passed: https://github.com/dscho/git/actions/runs/3539451056
>
> I also had a look at the range-diff between v1 and v2:
>
> -- snip --
> 1:  ef80c39de1e5 ! 1:  6d4607a4ee46 github-actions: run gcc-8 on ubuntu-20.04 image
>     @@ Commit message
>              ubuntu)
>                  ;;
>
>     +    In this way, we can change the "ubuntu-latest" runner image to any
>     +    version such as "ubuntu-22.04" to test CI behavior in advance.
>     +
>          Signed-off-by: Jiang Xin <zhiyou.jx@alibaba-inc.com>
>
> 2:  1d0903c8b2f9 ! 2:  eba96648368a ci: upgrade version of p4
>     @@ Metadata
>      Author: Jiang Xin <zhiyou.jx@alibaba-inc.com>
>
>       ## Commit message ##
>     -    ci: upgrade version of p4
>     +    ci: upgrade version of p4 to 21.2
>
>          There would be a segmentation fault when running p4 v16.2 on ubuntu
>          22.04 which is the latest version of ubuntu runner image for github
>     -    actions. Upgrade p4 from version 16.2 to 19.2 will fix this issue.
>     +    actions.
>
>     -    Also add some instructions to show errors of command "p4 -V", so we can
>     -    see why the output doesn't match.
>     +    By checking each version from [1], p4d version 21.1 and above can work
>     +    properly on ubuntu 22.04. But version 22.x will break some p4 test
>     +    cases. So p4 version 21.x is exactly the version we can use.
>     +
>     +    In addition to upgrade p4 from version 16.2 to 21.2, also add some
>     +    instructions to show errors of command "p4 -V", so we can see why the
>     +    command output doesn't match.
>     +
>     +    [1]: https://cdist2.perforce.com/perforce/
>
>          Signed-off-by: Jiang Xin <zhiyou.jx@alibaba-inc.com>
>     @@ ci/lib.sh: ubuntu)
>         # image.
>         # Keep that in mind when you encounter a broken OS X build!
>      -  export LINUX_P4_VERSION="16.2"
>     -+  export LINUX_P4_VERSION="19.2"
>     ++  export LINUX_P4_VERSION="21.2"
>         export LINUX_GIT_LFS_VERSION="1.5.2"
>
>         P4_PATH="$HOME/custom/p4"
> -:  ------------ > 3:  8e432f13bef8 ci: install python on ubuntu
> -- snap --
>
> The changes look good!
Thank you for providing this range-diff.

-- Jiang Xin

Previous: Johannes SchindelinNext: Ævar Arnfjörð Bjarmason
Message 15 of 47 in “Use fixed github-actions runner image”
  1. 0/2 Use fixed github-actions runner imageJiang Xin, Nov 23, 2022
  2. 1/2 github-actions: run gcc-8 on ubuntu-20.04 imageJiang Xin, Nov 23, 2022
  3. Johannes SchindelinNov 24, 2022
  4. 2/2 ci: upgrade version of p4Jiang Xin, Nov 23, 2022
  5. Johannes SchindelinNov 24, 2022
  6. Johannes SchindelinNov 24, 2022
  7. Johannes SchindelinNov 24, 2022
  8. Jiang XinNov 24, 2022
  9. Johannes SchindelinNov 24, 2022
  10. Jiang XinNov 24, 2022
  11. Johannes SchindelinNov 24, 2022
  12. 0/3 Fix broken CI on newer github-actions runner imageJiang Xin, Nov 24, 2022
  13. Johannes SchindelinNov 24, 2022
  14. Johannes SchindelinNov 24, 2022
  15. Jiang XinNov 24, 2022
  16. python 2 EOL (was: [PATCH v2 0/3] Fix broken CI on newer github-actions runner image)Ævar Arnfjörð Bjarmason, Nov 24, 2022
  17. Junio C HamanoNov 25, 2022
  18. 0/4 Fix broken CI on newer github-actions runner imageJiang Xin, Nov 24, 2022
  19. 0/4 Fix broken CI on newer github-actions runner imageJiang Xin, Nov 25, 2022
  20. 2/4 ci: remove the pipe after "p4 -V" to cache errorsJiang Xin, Nov 25, 2022
  21. Junio C HamanoNov 27, 2022
  22. Jiang XinNov 27, 2022
  23. 1/4 github-actions: run gcc-8 on ubuntu-20.04 imageJiang Xin, Nov 25, 2022
  24. Junio C HamanoNov 27, 2022
  25. 3/4 ci: p4 on Linux has the same version as on macOSJiang Xin, Nov 25, 2022
  26. Junio C HamanoNov 27, 2022
  27. 4/4 ci: install python on ubuntuJiang Xin, Nov 25, 2022
  28. Junio C HamanoNov 27, 2022
  29. Jiang XinNov 27, 2022
  30. Junio C HamanoNov 27, 2022
  31. 1/4 github-actions: run gcc-8 on ubuntu-20.04 imageJiang Xin, Nov 24, 2022
  32. Ævar Arnfjörð BjarmasonNov 24, 2022
  33. 2/4 ci: show error message of "p4 -V"Jiang Xin, Nov 24, 2022
  34. Ævar Arnfjörð BjarmasonNov 24, 2022
  35. Junio C HamanoNov 25, 2022
  36. 3/4 ci: p4 on Linux has the same version as on macOSJiang Xin, Nov 24, 2022
  37. 4/4 ci: install python on ubuntuJiang Xin, Nov 24, 2022
  38. 1/3 github-actions: run gcc-8 on ubuntu-20.04 imageJiang Xin, Nov 24, 2022
  39. Ævar Arnfjörð BjarmasonNov 24, 2022
  40. Junio C HamanoNov 25, 2022
  41. 2/3 ci: upgrade version of p4 to 21.2Jiang Xin, Nov 24, 2022
  42. Ævar Arnfjörð BjarmasonNov 24, 2022
  43. Jiang XinNov 24, 2022
  44. 3/3 ci: install python on ubuntuJiang Xin, Nov 24, 2022
  45. Ævar Arnfjörð BjarmasonNov 24, 2022
  46. Jiang XinNov 24, 2022
  47. Ævar Arnfjörð BjarmasonNov 24, 2022

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.