Re: [PATCH v2 0/3] Fix broken CI on newer github-actions runner image
- From
Johannes Schindelin <johannes.schindelin@gmx.de>
- Date
- Nov 24, 2022, 09:44 UTC
- Message-ID
- <2219s80r-q7s3-391o-o3or-7q70sn37ooo9@tzk.qr>
- In-Reply-To
- <20221124090545.4790-1-worldhello.net@gmail.com>
Hi,
On Thu, 24 Nov 2022, Jiang Xin wrote:
Show 34 quoted lines
> From: Jiang Xin <zhiyou.jx@alibaba-inc.com> > > GitHub CI runner image "ubuntu-latest" will upgrade to "ubuntu-22.04" > soon, and the CI runner image of my private host repository has > already been upgraded. > > Our CI will break on new runner image because there is not "gcc-8" > package in ubuntu-22.04. See log of CI#2: > > * https://github.com/jiangxin/git-ci-test/actions/runs/3537628107/jobs/5937769957 > > This issue is fixed in patch 1/3 by downgrade the version of the runner > image for jobs which need "gcc-8". But there are still some CI errors. > This is because p4/p4d version 16.2 cannot run on ubuntu-22.04. See this > log of CI#3: > > * https://github.com/jiangxin/git-ci-test/actions/runs/3537650146/jobs/5937813922 > > This issue is fixed in patch 2/3 by upgrade p4 and p4d. But all p4 > related test cases failed becasue python was missing on ubuntu-22.04. > See the log of CI#4: > > * https://github.com/jiangxin/git-ci-test/actions/runs/3537695959/jobs/5937929695 > > This issue is fixed in patch 3/3 by install python2/python3 on ubutnu. > > If install p4 version 22.2, will break several p4 related test cases, > see the log of CI#7: > > * https://github.com/jiangxin/git-ci-test/actions/runs/3538795233/jobs/5939989823 > > So we choose p4 21.2, and the final successful log of CI#8 is below: > > * https://github.com/jiangxin/git-ci-test/actions/runs/3538946849
ACK!
I verified that this patch series does the job, by applying it on top of `microsoft/git`'s tentative rebase to v2.39.0-rc0: https://github.com/dscho/git/actions/runs/3539338333/jobs/5941122554
This run was restricted to `linux-clang` and the p4 tests. I care a lot about not using more resources than one's fair share, therefore I wanted to avoid using build minutes unnecessarily during my debuging.
To build even more confidence in the patch series, I will now start a full run (which will take *a lot* of build minutes, unfortunately).
Thank you so much! Dscho