Re: [PATCH v7] core.fsync: documentation and user-friendly aggregate options
- From
- Neeraj Singh <nksingh85@gmail.com>
- Date
- Mar 15, 2022, 19:56 UTC
- Message-ID
- <CANQDOdcL7N=GOCf2iz0Pofxd=aR2qUD5uUarnMGO578edUPV_Q@mail.gmail.com>
- In-Reply-To
- <xmqqv8wfc8qb.fsf@gitster.g>
On Tue, Mar 15, 2022 at 12:32 PM Junio C Hamano <gitster@pobox.com> wrote:
Show 29 quoted lines
> > Neeraj Singh <nksingh85@gmail.com> writes: > > > This commit adds aggregate options for the core.fsync setting that are > > more user-friendly. These options are specified in terms of 'levels of > > safety', indicating which Git operations are considered to be sync > > points for durability. > > > > The new documentation is also included here in its entirety for ease of > > review. > > > > Signed-off-by: Neeraj Singh <neerajsi@microsoft.com> > > --- > > This revision fixes a grammatical mistake in the core.fsync documentation. > > Is this meant to be [PATCH v7 6/6] where 1-5/6 of v7 are supposed to > be identical to their counterparts of v6 and therefor not sent? Not > complaining, just double-checking, as I do not want to assume and > end up missing the final updates to the other 5. > > In the meantime, I'd assume that it is the case, and will fix the > author ident (you sent this from your gmail address) before > replacing the last bit. > > The only change from the previous round is "the platform default on > most platform" -> "the default on most platforms", which looks > sensible. > > Thanks.
Yes, that's right. I was trying out git-send-email for the first time. I didn't want to spam the list with a whole new series where only one patch had a change.
Show 20 quoted lines
> > 1: 39f4b94c2c ! 1: dfeab99d23 core.fsync: documentation and user-friendly aggregate options > @@ > ## Metadata ## > -Author: Neeraj Singh <neerajsi@microsoft.com> > +Author: Neeraj Singh <nksingh85@gmail.com> > > ## Commit message ## > core.fsync: documentation and user-friendly aggregate options > @@ Documentation/config/core.txt: core.whitespace:: > +is ignored. > ++ > +The empty string resets the fsync configuration to the platform > -+default. The platform default on most platform is equivalent to > ++default. The default on most platforms is equivalent to > +`core.fsync=committed,-loose-object`, which has good performance, > +but risks losing recent work in the event of an unclean system shutdown. > ++ > > Thanks.