Re: [PATCH v4] Thunderbird: fix appp.sh format problems

From: Marco Stornelli <marco.stornelli@gmail.com>
Date: Sep 4, 2012, 06:37 UTC
Message-ID: <CANGUGtBk7DME4pkhJhcYoaM-q_S+i9_6u_Ku-9N6D41Mx50ghg@mail.gmail.com>
In-Reply-To: <7voblmeua3.fsf@alter.siamese.dyndns.org>

2012/9/3 Junio C Hamano <gitster@pobox.com>:

Show 17 quoted lines

> Marco Stornelli <marco.stornelli@gmail.com> writes:
>
>> I tried the Johannes's script, but it seems it doesn't work well with
>> the pattern of format-patch (To: <mail1>,\n   <mail2>,\n
>> <mailN>). The multilines are not well managed.
>
> I am guessing that the reason why Jonahhes's "copy our headers out
> with continuation lines intact" approach does not work is because
> Thunderbird does not want to see its own header part (i.e. that
> which comes before that $SEP) contain RFC-2822 style continuation
> lines.
>
> Can you grab a typical input (i.e. the contents of what is passed as
> $1 to the appp.sh script) and show us how it looks like here so that
> we can take a look?  It would be fine to paste the contents, but we
> might want to protect it from MUA by doing an attachment or a
> pastebin URL.

I don't have thunderbird now but actually it's really simple:

Subject: To: Cc: $SEP

Each data must be in a signle line, for example "Cc: <mail1>,.....,<mailN>"

Show 7 quoted lines

>
> It appears that the original script tries very hard to keep the
> Subject: line at the beginning, but I am not sure if that is because
> Thunderbird wants to read its "$1" that way, or it is just that
> original appp.sh script happened to be written that way without real
> reason.  If I were updating this script, what I would do would be
> more like:

Ok, good coding then.

Regards,

Marco