Re: [PATCH v4] Thunderbird: fix appp.sh format problems

From: Junio C Hamano <gitster@pobox.com>
Date: Aug 31, 2012, 20:01 UTC
Message-ID: <7vk3wen84a.fsf@alter.siamese.dyndns.org>
In-Reply-To: <5040C59A.6090303@gmail.com>

Marco Stornelli <marco.stornelli@gmail.com> writes:

Show 16 quoted lines

> +PATCHTMP="${PATCH}.tmp"
> +
> +echo $MAILHEADER > $PATCHTMP
> +
> +export PATCHTMP
> +CCS=`perl -e 'local $/=undef; open FILE, $ENV{'PATCHTMP'}; $text=<FILE>;
> +close FILE; $addr = $1 if $text =~ /Cc: (.*?(,\n .*?)*)\n/s; $addr =~ s/\n//g;
> +print $addr;'`
> +
> +TO=`perl -e 'local $/=undef; open FILE, $ENV{'PATCHTMP'}; $text=<FILE>;
> +close FILE; $addr = $1 if $text =~ /To: (.*?(,\n .*?)*)\n/s; $addr =~ s/\n//g;
> +print $addr;'`
>  
> -CCS=`echo -e "$CMT_MSG\n$HEADERS" | sed -n -e 's/^Cc: \(.*\)$/\1,/gp' \
> -	-e 's/^Signed-off-by: \(.*\)/\1,/gp'`
> +rm -rf $PATCHTMP

One thing I forgot to say. Make sure you quote your variables (when in doubt, quote). Also make it a habit not to say "rm -r" when you know you are removing a regular file you created. I.e.

	rm -f "$PATCHTMP"