Re: [PATCH v4] Thunderbird: fix appp.sh format problems

From: Junio C Hamano <gitster@pobox.com>
Date: Sep 2, 2012, 20:42 UTC
Message-ID: <7voblognny.fsf@alter.siamese.dyndns.org>
In-Reply-To: <50425F8B.5020406@gmail.com>

Marco Stornelli <marco.stornelli@gmail.com> writes:

Show 15 quoted lines

> Il 01/09/2012 15:59, Johannes Sixt ha scritto:
>
>> Look how you write:
>>
>>    perl -e '... $ENV{'PATCHTMP'} ...'
>>
>> That is, perl actually sees this script:
>>
>>    ... $ENV{PATCHTMP} ...
>>
>> (no quotes around PATCHTMP). That my be perfectly valid perl, but is not
>> what you intended.
>
> I don't understand what you mean when you say "is not what you
> intended"...

When you wrote this:

    CCS=`perl -e 'local $/=undef; open FILE, $ENV{'PATCHTMP'};...

which one of the following did you mean to feed Perl?

 (1) open FILE, $ENV{'PATCHTMP'};
 (2) open FILE, $ENV{PATCHTMP};

The patch text makes it look as if you wanted to do (1), but what is fed to perl is (2), as Johannes points out.

Saying:

    CCS=`perl -e 'local $/=undef; open FILE, $ENV{PATCHTMP};...

would have been more natural if you really meant to do (2), don't you think? So what you wrote is at least misleading.

But I think I agree with Johannes's rewrite of the loop, so this may be a moot point.