git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH 1/2] t3200-branch: test setting branch as own upstream

From
Brian Gesiak <modocache@gmail.com>
Date
Feb 28, 2014, 06:17 UTC
Message-ID
<CAN7MxmWP9N==0DnoE-0=Xr7NWkNMSGBC+yiz1a3wS5EbHigvKg@mail.gmail.com>
In-Reply-To
<20140228053703.GA32556@sigill.intra.peff.net>
> For an operation like "git branch foo origin" where setting up the
> tracking is a side effect, a warning makes sense. But the sole purpose
> of the command above is to set the upstream, and we didn't do it; should
> this warning actually be upgraded to an error?

I agree. I originally wrote the test using test_expect_failure--imagine my surprise when the exit status was 0, despite the fact that the upstream wasn't set!

> This should use test_i18ncmp, as the string you are matching is
> internationalized.

Patch is on the way, just waiting for the tests to complete. Thanks for pointing that out! Also, sorry if it's in the Makefile somewhere, but is there an easy way to run just a single test file in the t directory?

- Brian Gesiak
Previous: Jeff KingNext: Jeff King
Message 6 of 22 in “t3200-branch: test setting branch as own upstream”
  1. 1/2 t3200-branch: test setting branch as own upstreamBrian Gesiak, Feb 28, 2014
  2. 2/2 branch: use skip_prefixBrian Gesiak, Feb 28, 2014
  3. Jeff KingFeb 28, 2014
  4. Junio C HamanoMar 3, 2014
  5. Jeff KingFeb 28, 2014
  6. Brian GesiakFeb 28, 2014
  7. Jeff KingFeb 28, 2014
  8. brian m. carlsonFeb 28, 2014
  9. Johannes SixtFeb 28, 2014
  10. Jeff KingFeb 28, 2014
  11. Jeff KingFeb 28, 2014
  12. Brian GesiakFeb 28, 2014
  13. Jeff KingFeb 28, 2014
  14. Brian GesiakFeb 28, 2014
  15. Jeff KingFeb 28, 2014
  16. Brian GesiakFeb 28, 2014
  17. Jeff KingFeb 28, 2014
  18. Matthieu MoyFeb 28, 2014
  19. branch: die when setting branch as own upstreamBrian Gesiak, Mar 1, 2014
  20. 3/3 branch: die when setting branch as own upstreamBrian Gesiak, Mar 1, 2014
  21. Brian GesiakMar 1, 2014
  22. Johannes SixtFeb 28, 2014

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.