git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH 1/2] t3200-branch: test setting branch as own upstream

From
Jeff King <peff@peff.net>
Date
Feb 28, 2014, 08:37 UTC
Message-ID
<20140228083718.GA11480@sigill.intra.peff.net>
In-Reply-To
<CAN7MxmXOvkrWPDEUH_Bqz5RVZUS7kuWkwi9kWmdwuwySszd=YA@mail.gmail.com>
On Fri, Feb 28, 2014 at 04:28:38PM +0900, Brian Gesiak wrote:
> I would be in favor of using test_i18ngrep, but it seems like this
> test file overwhelmingly uses test_(i18n)cmp, even when inspecting
> stderr output.

We generally prefer "cmp" checks to "grep" checks, because they are more rigorous. However, when testing human-readable output which may change, sometimes being too specific can simply make the tests brittle and annoying. Using a forgiving regex that matches keywords can be helpful. So there's definitely some room for judgement.

I think what you posted as v2 looks OK.
Show 5 quoted lines
> Making double-sure that all tests pass when run with "sh -x" seems
> like a larger endeavor.
> 
> Of course, I'd be happy to submit several patches if there's support
> for such a change. But as Peff points out it will be a large diff.
Yeah, I don't think it's worth the effort.

If you feel like continuing on this series, converting the warning() into a die() would be a much more productive use of time (but if you don't, I do not see any reason not to take the patches you've posted).

-Peff
Previous: Brian GesiakNext: Brian Gesiak
Message 13 of 22 in “t3200-branch: test setting branch as own upstream”
  1. 1/2 t3200-branch: test setting branch as own upstreamBrian Gesiak, Feb 28, 2014
  2. 2/2 branch: use skip_prefixBrian Gesiak, Feb 28, 2014
  3. Jeff KingFeb 28, 2014
  4. Junio C HamanoMar 3, 2014
  5. Jeff KingFeb 28, 2014
  6. Brian GesiakFeb 28, 2014
  7. Jeff KingFeb 28, 2014
  8. brian m. carlsonFeb 28, 2014
  9. Johannes SixtFeb 28, 2014
  10. Jeff KingFeb 28, 2014
  11. Jeff KingFeb 28, 2014
  12. Brian GesiakFeb 28, 2014
  13. Jeff KingFeb 28, 2014
  14. Brian GesiakFeb 28, 2014
  15. Jeff KingFeb 28, 2014
  16. Brian GesiakFeb 28, 2014
  17. Jeff KingFeb 28, 2014
  18. Matthieu MoyFeb 28, 2014
  19. branch: die when setting branch as own upstreamBrian Gesiak, Mar 1, 2014
  20. 3/3 branch: die when setting branch as own upstreamBrian Gesiak, Mar 1, 2014
  21. Brian GesiakMar 1, 2014
  22. Johannes SixtFeb 28, 2014

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.