git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH v3 04/13] run-command: make `exists_in_PATH()` non-static

From
Miriam R. <mirucam@gmail.com>
Date
Feb 9, 2020, 09:59 UTC
Message-ID
<CAN7CjDB8NKQg279WjT6kWNaENiBRSEqztL0g9HbnS6RB_ZV7+A@mail.gmail.com>
In-Reply-To
<4550b9a5-74ef-2739-990b-6f41f3319129@web.de>
Hi,
El sáb., 8 feb. 2020 a las 11:55, René Scharfe (<l.s.r@web.de>) escribió:
Show 11 quoted lines
>
> Am 08.02.20 um 10:06 schrieb Miriam Rubio:
> > From: Pranit Bauva <pranit.bauva@gmail.com>
> >
> > Removes the `static` keyword from `exists_in_PATH()` function
> > and declares the function in `run-command.h` file.
> > The function will be used in bisect_visualize() in a later
> > commit.
>
> I couldn't find the mentioned later commit in this series.  Do you
> actually still need to export exists_in_PATH()?

This series is part of a bigger patch series (https://public-inbox.org/git/20200120143800.900-1-mirucam@gmail.com/) that has been split as a suggestion of a reviewer in order to be easily reviewed. This first part is formed of preparatory/clean-up patches and all `bisect.c` libification work. The actual patch is one of the preparatory patches and the function will be used in the upcoming patch series.

Show 5 quoted lines
>
> And if yes: locate_in_PATH() splits PATH by colon.  That means it
> doesn't work on Windows, where the paths are separated by semicolons.
> exists_in_PATH() wraps it, so it shares that limitation.  Wouldn't that
> cause issues for your use?

Thank you, for point that out. I will check this. Best, Miriam

>
> René
Previous: René ScharfeNext: Taylor Blau
Message 7 of 18 in “Finish converting git bisect to C part 1”
  1. Miriam RubioFeb 8, 2020
  2. 01/13 bisect--helper: convert `vocab_*` char pointers to char arraysMiriam Rubio, Feb 8, 2020
  3. 02/13 bisect--helper: change `retval` to `res`Miriam Rubio, Feb 8, 2020
  4. 03/13 bisect: use the standard 'if (!var)' way to check for 0Miriam Rubio, Feb 8, 2020
  5. 04/13 run-command: make `exists_in_PATH()` non-staticMiriam Rubio, Feb 8, 2020
  6. René ScharfeFeb 8, 2020
  7. Miriam R.Feb 9, 2020
  8. Taylor BlauFeb 9, 2020
  9. 06/13 bisect: add enum to represent bisect returning codesMiriam Rubio, Feb 8, 2020
  10. 05/13 bisect--helper: introduce new `decide_next()` functionMiriam Rubio, Feb 8, 2020
  11. 07/13 bisect--helper: return error codes from `cmd_bisect__helper()`Miriam Rubio, Feb 8, 2020
  12. 08/13 bisect: libify `exit_if_skipped_commits` to `error_if_skipped*` and its dependentsMiriam Rubio, Feb 8, 2020
  13. 09/13 bisect: libify `bisect_checkout`Miriam Rubio, Feb 8, 2020
  14. 10/13 bisect: libify `check_merge_bases` and its dependentsMiriam Rubio, Feb 8, 2020
  15. 12/13 bisect: libify `handle_bad_merge_base` and its dependentsMiriam Rubio, Feb 8, 2020
  16. 11/13 bisect: libify `check_good_are_ancestors_of_bad` and its dependentsMiriam Rubio, Feb 8, 2020
  17. 13/13 bisect: libify `bisect_next_all`Miriam Rubio, Feb 8, 2020
  18. Miriam R.Feb 10, 2020

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.