From: Miriam R. <mirucam@gmail.com>
Date: Sun, 09 Feb 2020 09:59:47 GMT
Subject: Re: [PATCH v3 04/13] run-command: make `exists_in_PATH()` non-static
Message-ID: <CAN7CjDB8NKQg279WjT6kWNaENiBRSEqztL0g9HbnS6RB_ZV7+A@mail.gmail.com>
In-Reply-To: <4550b9a5-74ef-2739-990b-6f41f3319129@web.de>

Hi,

El sáb., 8 feb. 2020 a las 11:55, René Scharfe (<l.s.r@web.de>) escribió:
>
> Am 08.02.20 um 10:06 schrieb Miriam Rubio:
> > From: Pranit Bauva <pranit.bauva@gmail.com>
> >
> > Removes the `static` keyword from `exists_in_PATH()` function
> > and declares the function in `run-command.h` file.
> > The function will be used in bisect_visualize() in a later
> > commit.
>
> I couldn't find the mentioned later commit in this series.  Do you
> actually still need to export exists_in_PATH()?

This series is part of a bigger patch series
(https://public-inbox.org/git/20200120143800.900-1-mirucam@gmail.com/)
that has been split as a suggestion of a reviewer in order to be
easily reviewed.
This first part is formed of preparatory/clean-up patches and all
`bisect.c` libification work. The actual patch is one of the
preparatory patches and the function will be used in the upcoming
patch series.

>
> And if yes: locate_in_PATH() splits PATH by colon.  That means it
> doesn't work on Windows, where the paths are separated by semicolons.
> exists_in_PATH() wraps it, so it shares that limitation.  Wouldn't that
> cause issues for your use?

Thank you, for point that out.  I will check this.
Best,
Miriam
>
> René