git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH v3 04/13] run-command: make `exists_in_PATH()` non-static

From
Miriam R. <mirucam@gmail.com>
Date
Feb 10, 2020, 16:05 UTC
Message-ID
<CAN7CjDB=n=wfkEb=9kR7RKRm9oUAOsyxYJeU1w5MW=QH40kJVw@mail.gmail.com>
In-Reply-To
<47b51655-6373-0d5f-1397-8cbbb73d6661@web.de>
Hi René,
El lun., 10 feb. 2020 a las 16:43, René Scharfe (<l.s.r@web.de>) escribió:
>
> Hello Miriam,
>
> did you remove the Git mailing list from cc: intentionally?

No, no. Maybe I clicked reply, instead reply all. Sorry. It is included in CC now.

Show 18 quoted lines
>
> Am 10.02.20 um 12:16 schrieb Miriam R.:
> > El dom., 9 feb. 2020 a las 10:59, Miriam R. (<mirucam@gmail.com>) escribió:
> >> El sáb., 8 feb. 2020 a las 11:55, René Scharfe (<l.s.r@web.de>) escribió:
> >>> And if yes: locate_in_PATH() splits PATH by colon.  That means it
> >>> doesn't work on Windows, where the paths are separated by semicolons.
> >>> exists_in_PATH() wraps it, so it shares that limitation.  Wouldn't that
> >>> cause issues for your use?
> >>
> >> Thank you, for point that out.  I will check this.
> >
> > This function is used only to test if gitk exists. But as gitk does not work
> > on Windows, then I think it is all ok because the evaluation is going to
> > return false and nothing has to be changed.
>
> Now I'm confused, because I do use gitk on Windows.  The third
> screenshot on https://gitforwindows.org/ shows it as well, so you don't
> have to just take my word on it.

Ohh, as I'm not a Windows user, and after some google searches it seems to me it doesn't. It is clear that I was not asking the correct things, hehe. Thank you for the clarification.

Show 9 quoted lines
>
> > Also, as this patch is not really needed for this part1, I will move
> > it to the upcoming patch series.
>
> That makes sense.
>
> I guess it's to used in the C equivalent of the Shell function
> bisect_visualize(), which resolves gitk using type, calls it if it's
> found and falls back to git log if it isn't.
Exactly.
>Why not try to exec gitk
> and fall back to git log if that fails?
>
It seems a good solution for me :)

Thank you for reviewing. Best, Miriam.

> René
Previous: Miriam Rubio
Message 18 of 18 in “Finish converting git bisect to C part 1”
  1. Miriam RubioFeb 8, 2020
  2. 01/13 bisect--helper: convert `vocab_*` char pointers to char arraysMiriam Rubio, Feb 8, 2020
  3. 02/13 bisect--helper: change `retval` to `res`Miriam Rubio, Feb 8, 2020
  4. 03/13 bisect: use the standard 'if (!var)' way to check for 0Miriam Rubio, Feb 8, 2020
  5. 04/13 run-command: make `exists_in_PATH()` non-staticMiriam Rubio, Feb 8, 2020
  6. René ScharfeFeb 8, 2020
  7. Miriam R.Feb 9, 2020
  8. Taylor BlauFeb 9, 2020
  9. 06/13 bisect: add enum to represent bisect returning codesMiriam Rubio, Feb 8, 2020
  10. 05/13 bisect--helper: introduce new `decide_next()` functionMiriam Rubio, Feb 8, 2020
  11. 07/13 bisect--helper: return error codes from `cmd_bisect__helper()`Miriam Rubio, Feb 8, 2020
  12. 08/13 bisect: libify `exit_if_skipped_commits` to `error_if_skipped*` and its dependentsMiriam Rubio, Feb 8, 2020
  13. 09/13 bisect: libify `bisect_checkout`Miriam Rubio, Feb 8, 2020
  14. 10/13 bisect: libify `check_merge_bases` and its dependentsMiriam Rubio, Feb 8, 2020
  15. 12/13 bisect: libify `handle_bad_merge_base` and its dependentsMiriam Rubio, Feb 8, 2020
  16. 11/13 bisect: libify `check_good_are_ancestors_of_bad` and its dependentsMiriam Rubio, Feb 8, 2020
  17. 13/13 bisect: libify `bisect_next_all`Miriam Rubio, Feb 8, 2020
  18. Miriam R.Feb 10, 2020

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.