git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH 2/2] submodule.c: warn about missing submodule commit in recursive actions

From
MÅMartin Ågren <martin.agren@gmail.com>
Date
Sep 6, 2018, 06:22 UTC
Message-ID
<CAN0heSq1fNb6Wc1P0B3JQL3PA_yi329vbkG5pjWsCpYf8SDn5Q@mail.gmail.com>
In-Reply-To
<20180905231952.28145-2-sbeller@google.com>
> +       if (repo_submodule_init(&subrepo, the_repository, path) < 0)
> +               warning(_("Could not get submodule repository for submodule 's'"), path);

Missing "%" in format specifier, so `path` will never be used. Also, s/C/c/ at the start of the warning.

Thanks for marking with _().
Martin
Previous: Jonathan NiederNext: Jonathan Nieder
Message 4 of 6 in “submodule.c: convert submodule_move_head new argument to object id”
  1. 1/2 submodule.c: convert submodule_move_head new argument to object idStefan Beller, Sep 5, 2018
  2. 2/2 submodule.c: warn about missing submodule commit in recursive actionsStefan Beller, Sep 5, 2018
  3. Jonathan NiederSep 5, 2018
  4. Martin ÅgrenSep 6, 2018
  5. Jonathan NiederSep 5, 2018
  6. Junio C HamanoSep 6, 2018

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.