Re: [PATCH 2/2] submodule.c: warn about missing submodule commit in recursive actions
- From
- Martin Ågren <martin.agren@gmail.com>
- Date
- Sep 6, 2018, 06:22 UTC
- Message-ID
- <CAN0heSq1fNb6Wc1P0B3JQL3PA_yi329vbkG5pjWsCpYf8SDn5Q@mail.gmail.com>
- In-Reply-To
- <20180905231952.28145-2-sbeller@google.com>
> + if (repo_submodule_init(&subrepo, the_repository, path) < 0)
> + warning(_("Could not get submodule repository for submodule 's'"), path);Missing "%" in format specifier, so `path` will never be used. Also, s/C/c/ at the start of the warning.
Thanks for marking with _().
Martin