git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH 1/2] submodule.c: convert submodule_move_head new argument to object id

From
Junio C Hamano <gitster@pobox.com>
Date
Sep 6, 2018, 21:18 UTC
Message-ID
<xmqqa7ouz5mm.fsf@gitster-ct.c.googlers.com>
In-Reply-To
<20180905231952.28145-1-sbeller@google.com>
Stefan Beller <sbeller@google.com> writes:
Show 9 quoted lines
> All callers use oid_to_hex to convert the desired oid to a string before
> calling submodule_move_head. Defer the conversion to the
> submodule_move_head as it will turn out to be useful in a bit.
>
> Signed-off-by: Stefan Beller <sbeller@google.com>
> ---
>
> This is also part of the other series sent out yesterday, 
> https://public-inbox.org/git/20180904230149.180332-5-sbeller@google.com/
And what is your intention wrt the other one?

Do you want two separate copies of essentially the same patch queued as part of two separate topics? Did you change your mind since yesterday and decided to retract these patches, and instead concentrate on these two patches that address an issue with tigher focus before moving on to other things?

Exactly the same comment applies to this copy. It is somewhat disturbing to see that new and old, which correspond to each other and ought to be symmetrical, take the same "commit object" in different shapes.

Previous: Jonathan Nieder
Message 6 of 6 in “submodule.c: convert submodule_move_head new argument to object id”
  1. 1/2 submodule.c: convert submodule_move_head new argument to object idStefan Beller, Sep 5, 2018
  2. 2/2 submodule.c: warn about missing submodule commit in recursive actionsStefan Beller, Sep 5, 2018
  3. Jonathan NiederSep 5, 2018
  4. Martin ÅgrenSep 6, 2018
  5. Jonathan NiederSep 5, 2018
  6. Junio C HamanoSep 6, 2018

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.