From: Martin Ă…gren Date: Thu, 06 Sep 2018 06:22:20 GMT Subject: Re: [PATCH 2/2] submodule.c: warn about missing submodule commit in recursive actions Message-ID: In-Reply-To: <20180905231952.28145-2-sbeller@google.com> > + if (repo_submodule_init(&subrepo, the_repository, path) < 0) > + warning(_("Could not get submodule repository for submodule 's'"), path); Missing "%" in format specifier, so `path` will never be used. Also, s/C/c/ at the start of the warning. Thanks for marking with _(). Martin