Re: [PATCH 06/16] shortlog: add missing declaration

From: Felipe Contreras <felipe.contreras@gmail.com>
Date: Oct 31, 2013, 21:17 UTC
Message-ID: <CAMP44s2xYRP9rmpoQzDcdSWiYpU31FXEPW32Yqsn2DZjP4kD_A@mail.gmail.com>
In-Reply-To: <xmqqvc0d432e.fsf@gitster.dls.corp.google.com>

On Thu, Oct 31, 2013 at 2:07 PM, Junio C Hamano <gitster@pobox.com> wrote:

Show 26 quoted lines

> Felipe Contreras <felipe.contreras@gmail.com> writes:
>
>> On Thu, Oct 31, 2013 at 1:05 PM, Junio C Hamano <gitster@pobox.com> wrote:
>>> Felipe Contreras <felipe.contreras@gmail.com> writes:
>>>
>>>> Otherwise we would have to include commit.h.
>>>
>>> Was there a reason why commit.h is not included here, just like
>>> revision.h would include diff.h, so that users of shortlog.h do not
>>> have to worry about including commit.h themselves?
>>
>> Because you can't do:
>>
>> struct diff_options;
>> struct diff_options diffopt;
>>
>> The storage size is not known, but you can do:
>>
>> struct diff_options;
>> struct diff_options *diffopt;
>
> But so can you do
>
>         struct diff_options *diffopt;
>
> without the declaration, no?  That is:

Yes.

-- 
Felipe Contreras