Re: [PATCH 04/16] fetch: add missing documentation
On Thu, Oct 31, 2013 at 12:10 PM, Junio C Hamano <gitster@pobox.com> wrote:
> Felipe Contreras <felipe.contreras@gmail.com> writes:
Show 11 quoted lines
>> diff --git a/Documentation/git-fetch.txt b/Documentation/git-fetch.txt
>> index e08a028..7e75dc4 100644
>> --- a/Documentation/git-fetch.txt
>> +++ b/Documentation/git-fetch.txt
>> @@ -37,6 +37,9 @@ or from several repositories at once if <group> is given and
>> there is a remotes.<group> entry in the configuration file.
>> (See linkgit:git-config[1]).
>>
>> +When no remote is specified, by the default the `origin` remote will be used,
>
> I recall there were typofix comments on this line.
--- a/Documentation/git-fetch.txt
+++ b/Documentation/git-fetch.txt
@@ -37,7 +37,7 @@ or from several repositories at once if <group> is given and
there is a remotes.<group> entry in the configuration file.
(See linkgit:git-config[1]).
-When no remote is specified, by the default the `origin` remote will be used,
+When no remote is specified, by default the `origin` remote will be used,
unless there's an upstream branch configured for the current branch.
OPTIONS
>> +unless there's an upstream branch configured for the current branch.
>
> Also there was a phrasing comment on this one, I think.
There was no constructive comment, no alternative was proposed.
The conclusion of the discussion (at least mine) is that the phrasing is fine.
> Resending without rerolling is not very much appreciated.
I missed a valid comment in one of my 160 pending patches. Sue me.
--
Felipe Contreras
Felipe Contreras <felipe.contreras@gmail.com>