Re: [PATCH v5 01/15] Add new git-related helper to contrib

From: Felipe Contreras <felipe.contreras@gmail.com>
Date: May 19, 2013, 15:45 UTC
Message-ID: <CAMP44s2v5Z=7cJ4-3WeqVHAqxk1sWVT-VkOufK5CeCVcS8Xh8g@mail.gmail.com>
In-Reply-To: <CALkWK0kuj00uUW5C5zKyaCBM72HBzxAk9G2UT1P3bKx9Lc8tkg@mail.gmail.com>

On Sun, May 19, 2013 at 10:17 AM, Ramkumar Ramachandra <artagnon@gmail.com> wrote:

Show 5 quoted lines

> Ramkumar Ramachandra wrote:
>> There's a non-optional space before the "<email>" in your regex, which
>> is what I was pointing out.
>
> Er, scratch that.  It's the space after the "Whatevered-by:"

It doesn't really matter. We can operate under the assumption that there will always be a name and remove the extra code in fmt_person(), IIRC it was because of the muttrc simplification which I don't think makes sense any more. It's still possible that the name will be missing, but I don't personally care, it would probably work for 99.99% of the cases.

-- 
Felipe Contreras