Re: [PATCH v5 01/15] Add new git-related helper to contrib
- From
Ramkumar Ramachandra <artagnon@gmail.com>
- Date
- May 19, 2013, 15:15 UTC
- Message-ID
- <CALkWK0mA9zWjco1fYRu4O2QmMRJE7vd2Z3CyJj=a1VxCyymMvQ@mail.gmail.com>
- In-Reply-To
- <CAMP44s1xguzX=iavUJxYXBEPOpGvJtJ_7FDHNCWMrF6qxOsuOQ@mail.gmail.com>
Felipe Contreras wrote:
>> Will $2 ever be nil (from fmt_person)? ie. Why are you checking for >> the special case " <\S+?>$"? > > Yes, '<email>' was valid in earlier versions of git.
There's a non-optional space before the "<email>" in your regex, which is what I was pointing out.