git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH v5 15/15] contrib: related: fix parsing of rev-list args

From
Felipe Contreras <felipe.contreras@gmail.com>
Date
May 18, 2013, 11:46 UTC
Message-ID
<1368877615-9563-16-git-send-email-felipe.contreras@gmail.com>
In-Reply-To
<1368877615-9563-1-git-send-email-felipe.contreras@gmail.com>
For example '-1'.
Signed-off-by: Felipe Contreras <felipe.contreras@gmail.com>
---
 contrib/related/git-related | 9 ++++++---
 1 file changed, 6 insertions(+), 3 deletions(-)
diff --git a/contrib/related/git-related b/contrib/related/git-related
index 62c9b56..69737ac 100755
--- a/contrib/related/git-related
+++ b/contrib/related/git-related
@@ -29,7 +29,8 @@ begin
       $show_commits = v || true
     end
   end.parse!
-rescue OptionParser::InvalidOption
+rescue OptionParser::InvalidOption => e
+  $rev_args += e.args
 end
 
 def get_mailmap(filename)
@@ -241,9 +242,11 @@ class Commits
 
     case revs.size
     when 1
-      committish = [ '%s..HEAD' % revs[0] ]
+      r = revs[0]
+      r = '^' + r if r[0] != '-'
+      args = [ r, 'HEAD' ]
     else
-      committish = revs
+      args = revs
     end
 
     source = nil
-- 
1.8.3.rc2.542.g24820ba
Previous: Felipe Contreras
Message 28 of 28 in “New git-related helper”
  1. 00/15 New git-related helperFelipe Contreras, May 18, 2013
  2. 01/15 Add new git-related helper to contribFelipe Contreras, May 18, 2013
  3. Felipe ContrerasMay 18, 2013
  4. Junio C HamanoMay 19, 2013
  5. Felipe ContrerasMay 19, 2013
  6. Ramkumar RamachandraMay 19, 2013
  7. Felipe ContrerasMay 19, 2013
  8. Ramkumar RamachandraMay 19, 2013
  9. Felipe ContrerasMay 19, 2013
  10. David AguilarMay 19, 2013
  11. Ramkumar RamachandraMay 19, 2013
  12. Ramkumar RamachandraMay 19, 2013
  13. Felipe ContrerasMay 19, 2013
  14. Felipe ContrerasMay 19, 2013
  15. 02/15 contrib: related: add option parsingFelipe Contreras, May 18, 2013
  16. 03/15 contrib: related: sort by amount of involvementFelipe Contreras, May 18, 2013
  17. 04/15 contrib: related: print the amount of involvementFelipe Contreras, May 18, 2013
  18. 05/15 contrib: related: add helper Person classesFelipe Contreras, May 18, 2013
  19. 06/15 contrib: related: show role countFelipe Contreras, May 18, 2013
  20. 07/15 contrib: related: add support for more rolesFelipe Contreras, May 18, 2013
  21. 08/15 contrib: related: group persons with same emailFelipe Contreras, May 18, 2013
  22. 09/15 contrib: related: add mailmap supportFelipe Contreras, May 18, 2013
  23. 10/15 contrib: related: allow usage on other directoriesFelipe Contreras, May 18, 2013
  24. 11/15 contrib: related: add support for multiple patchesFelipe Contreras, May 18, 2013
  25. 12/15 contrib: related: add option to show commitsFelipe Contreras, May 18, 2013
  26. 13/15 contrib: related: add option to parse from committishFelipe Contreras, May 18, 2013
  27. 14/15 contrib: related: parse committish like format-patchFelipe Contreras, May 18, 2013
  28. 15/15 contrib: related: fix parsing of rev-list argsFelipe Contreras, May 18, 2013

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.