git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH 2/3] completion: remove old code

From
Felipe Contreras <felipe.contreras@gmail.com>
Date
Jan 30, 2012, 10:51 UTC
Message-ID
<CAMP44s2j+qotu8Fb-1qq9bqHqt+ZF877YzZFXHiMo7Z_BGzTMA@mail.gmail.com>
In-Reply-To
<7vd3a1erwf.fsf@alter.siamese.dyndns.org>
On Mon, Jan 30, 2012 at 6:27 AM, Junio C Hamano <gitster@pobox.com> wrote:
Show 7 quoted lines
> Felipe Contreras <felipe.contreras@gmail.com> writes:
>
>> OK, maybe some people use it, but most likely they are using an old
>> version of git, and thus an old version of the completion script.
>
> Please adjust your attitude about backward compatibility to match the
> standard used for other parts of Git.

What attitude? I am simply stating a fact. How much percentage of people do you think still have .git/remotes around? How many people do you think have clones more than 3 years old? And how many of these people would complain if remotes were not properly completed for these repos?

I doubt anybody would have complained, but I guess we would never know, because I already proposed a solution that would work for them and only uses a *single* line of code, unlike the current 40 ones.

I don't see what is the problem with the attitude of sending a patch to remove code that most likely nobody cares about (neither you or I have numbers on this), and then finding an alternative when people do care about it.

Cheers.
-- 
Felipe Contreras
Previous: Junio C HamanoNext: Frans Klaver
Message 14 of 28 in “completion: trivial cleanups”
  1. 0/3 completion: trivial cleanupsFelipe Contreras, Jan 29, 2012
  2. 1/3 completion: be nicer with zshFelipe Contreras, Jan 29, 2012
  3. Junio C HamanoJan 30, 2012
  4. Junio C HamanoJan 30, 2012
  5. Felipe ContrerasJan 30, 2012
  6. Felipe ContrerasJan 30, 2012
  7. Junio C HamanoJan 30, 2012
  8. Felipe ContrerasJan 30, 2012
  9. 2/3 completion: remove old codeFelipe Contreras, Jan 29, 2012
  10. Jonathan NiederJan 30, 2012
  11. Felipe ContrerasJan 30, 2012
  12. Jonathan NiederJan 30, 2012
  13. Junio C HamanoJan 30, 2012
  14. Felipe ContrerasJan 30, 2012
  15. Frans KlaverJan 30, 2012
  16. Felipe ContrerasJan 30, 2012
  17. Frans KlaverJan 30, 2012
  18. Felipe ContrerasJan 30, 2012
  19. Jonathan NiederJan 30, 2012
  20. 3/3 completion: remove unused codeFelipe Contreras, Jan 29, 2012
  21. Jonathan NiederJan 30, 2012
  22. Jonathan NiederJan 30, 2012
  23. Felipe ContrerasJan 30, 2012
  24. Thomas RastJan 30, 2012
  25. Junio C HamanoJan 30, 2012
  26. Felipe ContrerasJan 30, 2012
  27. Thomas RastJan 30, 2012
  28. Felipe ContrerasJan 30, 2012

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.