Re: [PATCH 2/3] completion: remove old code

From: Felipe Contreras <felipe.contreras@gmail.com>
Date: Jan 30, 2012, 03:24 UTC
Message-ID: <CAMP44s1H6Db6Xq_iZseXppaTwpBCeu14ySgPfmoQnpELfywQ-Q@mail.gmail.com>
In-Reply-To: <20120130023642.GA14986@burratino>

On Mon, Jan 30, 2012 at 4:36 AM, Jonathan Nieder <jrnieder@gmail.com> wrote:

Show 14 quoted lines

> Felipe Contreras wrote:
>
>> We don't need to check for GIT_DIR/remotes, right? This was removed long
>> time ago.
>
> I don't follow.  fetch, push, and remote still look in .git/remotes
> like they always did, last time I checked.
>
> Perhaps you mean that /usr/share/git-core/templates/ no longer
> contains a remotes/ directory?  That's true but not particularly
> relevant.  A more relevant detail would be that very few people _use_
> the .git/remotes feature, though it is not obvious to me whether that
> justifies removing this code from the git-completion script that
> already works.

The problem is all the 'nullglob' stuff. It's *a lot* of code for this feature that nobody uses.

OK, maybe some people use it, but most likely they are using an old version of git, and thus an old version of the completion script.

Anyway, aren't there easier ways to get this? Perhaps first checking if the directory exists, to avoid wasting cycles.

Something like:
  test -d "$d/remotes" && ls -1 "$d/remotes"

-- 
Felipe Contreras