Re: [PATCH 3/3] completion: remove unused code

From: Felipe Contreras <felipe.contreras@gmail.com>
Date: Jan 30, 2012, 13:51 UTC
Message-ID: <CAMP44s2OQY3Pym5uqxvEE_yYa0xLboT=mjv+DFCDo8_xobGO3w@mail.gmail.com>
In-Reply-To: <87pqe1nx9a.fsf@thomas.inf.ethz.ch>

On Mon, Jan 30, 2012 at 3:19 PM, Thomas Rast <trast@inf.ethz.ch> wrote:

Show 24 quoted lines

> Felipe Contreras <felipe.contreras@gmail.com> writes:
>
>> On Mon, Jan 30, 2012 at 10:22 AM, Junio C Hamano <jch2355@gmail.com> wrote:
>>> Thomas Rast <trast@inf.ethz.ch> wrote:
>>>>Felipe Contreras <felipe.contreras@gmail.com> writes:
>>>>
>>>>> No reason. I hope they read the mailing list, otherwise I'll resend
>>>>> and CC them. A get_maintainers script, or something like that would
>>>>> make things easier.
>>>>
>>>>I simply use
>>>>
>>>>  git shortlog -sn --no-merges v1.7.0.. -- contrib/completion/
>>>>
>>>>(In many parts the revision limiter can be omitted without losing much,
>>>>but e.g. here this drops Shawn who hasn't worked on it since 2009.)
>>>
>>> Or "--since=1.year", which you can keep using forever without adjusting.
>>
>> Perhaps something like that can be stored in a script somewhere in
>> git's codebase so that people can set sendemail.cccmd to that.
>
> Umm, that seems rather AI-complete.  You should always compile the list
> by hand.

Why? Take a look at the Linux kernel; having tons of contributors, many still haven't learned the ropes, and looking at MAINTAIERS, plus the output of 'git blame', for potentially dozens of patches is too burdensome, which is why they have 'scripts/get_maintainer.pl' that does a pretty good job of figuring out who to cc so you don't have to think about it.

> Ok, this got rather long-winded.  But I think the bottom line is, trying
> to put this in sendemail.cccmd is trying to script common sense.

It's still better than nothing.

I once wrote a much smarter script[1], but it never go into the tree.

The output I get is this: "Shawn O. Pearce" <spearce@spearce.org>> "Jonathan Nieder" <jrnieder@gmail.com> "Mark Lodato" <lodatom@gmail.com> "Junio C Hamano" <junkio@cox.net> "Ted Pavlic" <ted@tedpavlic.com>

Note: seems like there's a bug with git blame -P:
% g blame -p -L 2730,+33 contrib/completion/git-completion.bash | grep
author-mail

And if this script is such a bad idea; why do you think sendmail.cccmd exists?

I think we should have a simple script that at least does something sensible, at least in contrib, but I hope we could even have a standard git-cccmd that all projects could use.

It looks like my ruby script never had much of a chance getting anywhere, so would it be accepted in another format? perl? python? bash?

Cheers.

[1] http://thread.gmane.org/gmane.comp.version-control.git/130391

-- 
Felipe Contreras