Re: [PATCH 12/20] remote-bzr: split marks file

From: Felipe Contreras <felipe.contreras@gmail.com>
Date: Apr 26, 2013, 23:36 UTC
Message-ID: <CAMP44s2dzV428+_ZENg_Z5n=rnvqz1ZNAxnjsqCtLSJK-9PZZg@mail.gmail.com>
In-Reply-To: <1366938488-25425-13-git-send-email-felipe.contreras@gmail.com>

On Thu, Apr 25, 2013 at 8:08 PM, Felipe Contreras <felipe.contreras@gmail.com> wrote:

Show 5 quoted lines

> This way all the remotes can share the same git objects, and the same
> marks. The information we want to store per remote is very small.
>
> The code transparently converts from one organization of marks, to the
> other. It's rather smooth and there shouldn't be any issues.

Please drop this patch. While testing essentially the same functionality in remote-hg I noticed that it doesn't work when dealing with more than one remote. It's not clear if the marks can be shared at all, and if possible, it would be very tricky.

Better drop it for now. I've tested that dropping this patch doesn't cause an conflicts for the rest of the series.

And in case anybody is thinking that remote-bzr is really a too fast moving target; even if this managed to land in 'master', it's likely that people were not able to push at all, and in fact, many were not even able to clone in 1.8.2. So, hardly could be considered a regression. Nevertheless, I caught it in time.

Cheers.

-- 
Felipe Contreras