Re: [PATCH] Add tcsh-completion support to contrib by using git-completion.bash

From: Felipe Contreras <felipe.contreras@gmail.com>
Date: Nov 15, 2012, 02:40 UTC
Message-ID: <CAMP44s2Nsxu9CsTxAXiSamjA5SqxwB2qWx72vu8Mit1ruLMWJg@mail.gmail.com>
In-Reply-To: <20121114001159.GA14631@goldbirke>

On Wed, Nov 14, 2012 at 1:11 AM, SZEDER Gábor <szeder@ira.uka.de> wrote:

Show 10 quoted lines

> On Tue, Nov 13, 2012 at 07:31:45PM +0100, Felipe Contreras wrote:
>> On Mon, Nov 12, 2012 at 9:07 PM, Marc Khouzam <marc.khouzam@gmail.com> wrote:
>> > +       # Call _git() or _gitk() of the bash script, based on the first
>> > +       # element of the command-line
>> > +       _${COMP_WORDS[0]}
>>
>> You might want to use __${COMP_WORDS[0]}_main instead.
>
> That wouldn't work.  __git_main() doesn't set up the
> command-line-specific variables, but the wrapper around it does.

Yeah, but you can set those command-line-specific variables manually, like the zsh completion wrapper does.

The problem with the _git wrapper is that it will call the bash-specific complete command.

Show 11 quoted lines

>> > +# Make the script executable if it is not
>> > +if ( ! -x ${__git_tcsh_completion_script} ) then
>> > +       chmod u+x ${__git_tcsh_completion_script}
>> > +endif
>>
>> Why not just source it?
>
> The goal is to re-use a Bash script to do completion in tcsh.  They
> are two different breeds, tcsh doesn't grok bash.  So sourcing the
> completion script is not an option, but we can still run it via Bash
> and use it's results.

I see, but the tcsh script can do something like this:

bash <<\EOF echo $BASH \EOF

Cheers.

-- 
Felipe Contreras