Re: [PATCH] Add tcsh-completion support to contrib by using git-completion.bash

From: SZEDER Gábor <szeder@ira.uka.de>
Date: Nov 14, 2012, 00:11 UTC
Message-ID: <20121114001159.GA14631@goldbirke>
In-Reply-To: <CAMP44s3imos4DksroRkZ3K6una5H916gvtqttJQna8yGG8XhsQ@mail.gmail.com>

On Tue, Nov 13, 2012 at 07:31:45PM +0100, Felipe Contreras wrote:

Show 6 quoted lines

> On Mon, Nov 12, 2012 at 9:07 PM, Marc Khouzam <marc.khouzam@gmail.com> wrote:
> > +       # Call _git() or _gitk() of the bash script, based on the first
> > +       # element of the command-line
> > +       _${COMP_WORDS[0]}
> 
> You might want to use __${COMP_WORDS[0]}_main instead.

That wouldn't work. __git_main() doesn't set up the command-line-specific variables, but the wrapper around it does.

Show 6 quoted lines

> > +# Make the script executable if it is not
> > +if ( ! -x ${__git_tcsh_completion_script} ) then
> > +       chmod u+x ${__git_tcsh_completion_script}
> > +endif
> 
> Why not just source it?

The goal is to re-use a Bash script to do completion in tcsh. They are two different breeds, tcsh doesn't grok bash. So sourcing the completion script is not an option, but we can still run it via Bash and use it's results.