Re: [PATCH] tcsh-completion re-using git-completion.bash

From: Felipe Contreras <felipe.contreras@gmail.com>
Date: Nov 16, 2012, 01:41 UTC
Message-ID: <CAMP44s0Guq0nYJEfbvNDyt8Oqaux-cXbTsyro6pxUnEpA4+XOw@mail.gmail.com>
In-Reply-To: <1352980269-15569-1-git-send-email-marc.khouzam@gmail.com>

On Thu, Nov 15, 2012 at 12:51 PM, Marc Khouzam <marc.khouzam@gmail.com> wrote:

Show 15 quoted lines

> The current tcsh-completion support for Git, as can be found on the
> Internet, takes the approach of defining the possible completions
> explicitly.  This has the obvious draw-back to require constant
> updating as the Git code base evolves.
>
> The approach taken by this commit is to to re-use the advanced bash
> completion script and use its result for tcsh completion.  This is
> achieved by executing (versus sourcing) the bash script and
> outputting the completion result for tcsh consumption.
>
> Three solutions were looked at to implement this approach with (A)
> being retained:
>
>   A) Modifications:
>           git-completion.bash and new git-completion.tcsh

As I said, I don't think this is needed. It can be done in a single stand-alone script without modifications to git-completion.bash.

This works:

set called = ($_) set script = "${called[2]}.tmp"

cat <<\EOF > $script source "$HOME/.git-completion.sh"

# Set COMP_WORDS in a way that can be handled by the bash script. COMP_WORDS=($1)

# Set COMP_CWORD to the cursor location as bash would.
if [ -n "${2-}" ]; then
	COMP_CWORD=$2
else
	# Assume the cursor is at the end of parameter #1.
	# We must check for a space as the last character which will
	# tell us that the previous word is complete and the cursor
	# is on the next word.
	if [ "${1: -1}" == " " ]; then
		# The last character is a space, so our location is at the end
		# of the command-line array
		COMP_CWORD=${#COMP_WORDS[@]}
	else
		# The last character is not a space, so our location is on the
		# last word of the command-line array, so we must decrement the
		# count by 1
		COMP_CWORD=$((${#COMP_WORDS[@]}-1))
	fi
fi

# Call _git() or _gitk() of the bash script, based on the first # element of the command-line _${COMP_WORDS[0]}

IFS=$'\n' echo "${COMPREPLY[*]}" \EOF

complete git 'p/*/`bash ${script} "${COMMAND_LINE}" | sort | uniq`/' complete gitk 'p/*/`bash ${script} "${COMMAND_LINE}" | sort | uniq`/'

-- 
Felipe Contreras