Re: [PATCH 6/7] sha1_name: prepare to introduce AT_KIND_PUSH

From: Felipe Contreras <felipe.contreras@gmail.com>
Date: May 24, 2013, 13:22 UTC
Message-ID: <CAMP44s2AxHkx54HzCCK5nUsexAhWy4J_oqg4wNu0=FzvEYtXAg@mail.gmail.com>
In-Reply-To: <1369321970-7759-7-git-send-email-artagnon@gmail.com>

On Thu, May 23, 2013 at 10:12 AM, Ramkumar Ramachandra <artagnon@gmail.com> wrote:

> Introduce an AT_KIND_PUSH to be represented as "@{p[ush]}".  Determine
> it using branch.remote.push_refspec.

I think the semantics of this don't make any sense.

  git push branch@{upstream}

Is very clear: push upstream of branch.

  git push branch@{push}

Is not clear at all: push push of branch?

Is it a noun, or a verb?

I would expect branch@{X} to be 'the X of branch', and "the push of branch" doesn't make sense. Whatever X ends up being, it should be a noun.

-- 
Felipe Contreras