Re: [PATCH 7/7] sha1_name: implement finding @{push}
- From
Duy Nguyen <pclouds@gmail.com>
- Date
- May 24, 2013, 16:09 UTC
- Message-ID
- <CACsJy8CV192WVW8u6YRnbf6Ue6tFbzyiCARwicwzapSZucaaMw@mail.gmail.com>
- In-Reply-To
- <1369321970-7759-8-git-send-email-artagnon@gmail.com>
(I haven't caught up with git mails lately, but the @{special} refactoring caught my eyes..)
On Thu, May 23, 2013 at 10:12 PM, Ramkumar Ramachandra <artagnon@gmail.com> wrote:
> Try this now: configure your current branch's pushremote to push to
> "refs/heads/*:refs/heads/rr/*". Now, type 'git show @{p}'. Voila!Voila what? Why not avoid guessing game and describe what the patch is for?
Show 18 quoted lines
> +static void find_push_ref(struct branch *branch) {
> + struct remote *remote = pushremote_get(NULL);
> + const struct refspec *pat = NULL;
> + char raw_ref[PATH_MAX];
> + struct ref *this_ref;
> + char *dst_name;
> + int len;
> +
> + sprintf(raw_ref, "refs/heads/%s", branch->name);
> + len = strlen(raw_ref) + 1;
> + this_ref = xcalloc(1, sizeof(*this_ref) + len);
> + memcpy(this_ref->name, raw_ref, len);
> +
> + dst_name = get_ref_match(remote->push, remote->push_refspec_nr,
> + this_ref, MATCH_REFS_ALL, 0, &pat);
> + printf("dst_name = %s\n", dst_name);
> +}
> +Isn't this an abuse of extended sha-1 syntax? How can I combine this with other @{}, ^, ~...? -- Duy