Re: [PATCH 7/7] sha1_name: implement finding @{push}

From: Ramkumar Ramachandra <artagnon@gmail.com>
Date: May 24, 2013, 16:29 UTC
Message-ID: <CALkWK0=LXNRaWz0vN_FwmJKbXT+W11mHABqzSJnbm_izQ0Ttrw@mail.gmail.com>
In-Reply-To: <CACsJy8AHX0181uON5Aa7oJzX8j3qAA26Ymh5G3YEGidD4O5zvA@mail.gmail.com>

Duy Nguyen wrote:

> Then "show @{p}" should show the tip commit of rr/master, not the ref
> name.

Yes, that is correct.

> rev-parse (with an option, maybe) may be a better place for
> this.

Er, no. I actually want things like diff @{p}..HEAD. I want it to be a first-class revision, just like @{u}.

> I did not expect @{p} to printf(). If it's part of get_sha1(), how can
> it return an sha-1? And the cover letter said "7/7 is the meat". Not
> very informative.

I also said sorry for the horrible mess ;) Yes, it's obviously not supposed to print and die() with a "Done!": this was a development session, and I hit send-email as soon as I got the right output. It's supposed to behave exactly like @{u} (failing to resolve occasionally).