git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH 2/4] remote-helpers: rename tests

From
Felipe Contreras <felipe.contreras@gmail.com>
Date
May 29, 2013, 17:56 UTC
Message-ID
<CAMP44s2-Of=AS9Jg7YAXnZ2346ozWPS4gL5irh0devwpkdBKmQ@mail.gmail.com>
In-Reply-To
<7v8v2xvhbu.fsf@alter.siamese.dyndns.org>
On Wed, May 29, 2013 at 12:14 PM, Junio C Hamano <gitster@pobox.com> wrote:
Show 23 quoted lines
> Felipe Contreras <felipe.contreras@gmail.com> writes:
>
>>> I do not see how it makes sense to copy how they deviate from us
>>> back to our codebase, especially if we plan to eventually move some
>>> of these tests out of contrib/ area, but even without such a plan in
>>> the future.
>>
>> They deviate from us, we deviate from them, whatever. We are a single project,
>> what more than one project does is more standard.
>
> We are a single project, so it is better to consistently follow the
> local convention established here.
>
> If your proposal were to
>
>  - Convert t/*.sh to end with .t intead, to change the project
>    convention, and
>
>  - Make contrib/ things also conform to that new convention.
>
> it may make some sense to discuss the pros and cons of such a move,
> but changing only contrib/ has no effect other than making it even
> less consistent with the rest of the project.

It's already inconsistent with the rest of the project, as they are not named tNNNN-foo.sh.

If you want I can give it a try at renaming all the tests in the whole project to *.t, but I don't think you are truly interested in finding a better extension for our tests.

-- 
Felipe Contreras
Previous: Junio C HamanoNext: Junio C Hamano
Message 7 of 12 in “remote-helpers: test reorganization”
  1. 0/4 remote-helpers: test reorganizationFelipe Contreras, May 25, 2013
  2. 1/4 remote-helpers: generate scriptsFelipe Contreras, May 25, 2013
  3. 2/4 remote-helpers: rename testsFelipe Contreras, May 25, 2013
  4. Junio C HamanoMay 28, 2013
  5. Felipe ContrerasMay 29, 2013
  6. Junio C HamanoMay 29, 2013
  7. Felipe ContrerasMay 29, 2013
  8. Junio C HamanoMay 29, 2013
  9. Felipe ContrerasMay 29, 2013
  10. 3/4 remote-helpers: allow direct test executionFelipe Contreras, May 25, 2013
  11. 4/4 remote-helpers: add exec-path linksFelipe Contreras, May 25, 2013
  12. Junio C HamanoMay 28, 2013

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.