From: Felipe Contreras Date: Wed, 29 May 2013 17:56:36 GMT Subject: Re: [PATCH 2/4] remote-helpers: rename tests Message-ID: In-Reply-To: <7v8v2xvhbu.fsf@alter.siamese.dyndns.org> On Wed, May 29, 2013 at 12:14 PM, Junio C Hamano wrote: > Felipe Contreras writes: > >>> I do not see how it makes sense to copy how they deviate from us >>> back to our codebase, especially if we plan to eventually move some >>> of these tests out of contrib/ area, but even without such a plan in >>> the future. >> >> They deviate from us, we deviate from them, whatever. We are a single project, >> what more than one project does is more standard. > > We are a single project, so it is better to consistently follow the > local convention established here. > > If your proposal were to > > - Convert t/*.sh to end with .t intead, to change the project > convention, and > > - Make contrib/ things also conform to that new convention. > > it may make some sense to discuss the pros and cons of such a move, > but changing only contrib/ has no effect other than making it even > less consistent with the rest of the project. It's already inconsistent with the rest of the project, as they are not named tNNNN-foo.sh. If you want I can give it a try at renaming all the tests in the whole project to *.t, but I don't think you are truly interested in finding a better extension for our tests. -- Felipe Contreras