Re: [PATCH 2/4] remote-helpers: rename tests

From: Junio C Hamano <gitster@pobox.com>
Date: May 29, 2013, 18:44 UTC
Message-ID: <7v61y1tymh.fsf@alter.siamese.dyndns.org>
In-Reply-To: <CAMP44s2-Of=AS9Jg7YAXnZ2346ozWPS4gL5irh0devwpkdBKmQ@mail.gmail.com>

Felipe Contreras <felipe.contreras@gmail.com> writes:

Show 27 quoted lines

> On Wed, May 29, 2013 at 12:14 PM, Junio C Hamano <gitster@pobox.com> wrote:
>> Felipe Contreras <felipe.contreras@gmail.com> writes:
>>
>>>> I do not see how it makes sense to copy how they deviate from us
>>>> back to our codebase, especially if we plan to eventually move some
>>>> of these tests out of contrib/ area, but even without such a plan in
>>>> the future.
>>>
>>> They deviate from us, we deviate from them, whatever. We are a single project,
>>> what more than one project does is more standard.
>>
>> We are a single project, so it is better to consistently follow the
>> local convention established here.
>>
>> If your proposal were to
>>
>>  - Convert t/*.sh to end with .t intead, to change the project
>>    convention, and
>>
>>  - Make contrib/ things also conform to that new convention.
>>
>> it may make some sense to discuss the pros and cons of such a move,
>> but changing only contrib/ has no effect other than making it even
>> less consistent with the rest of the project.
>
> It's already inconsistent with the rest of the project, as they are
> not named tNNNN-foo.sh.

Correct; that is why I said "even less consistent".

> If you want I can give it a try at renaming all the tests in the whole
> project to *.t, but I don't think you are truly interested in finding
> a better extension for our tests.

Again, correct. I do not think it is worth the trouble to renaming them to *.t at this moment.

Having said that, I suspect that in the very longer term it might turn out to be a good thing to do (if we want to make our test suite runnable under other people's tools that expect .t suffix, for example). But I do not think that is the topic of this patch under discussion.