git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] Add new git-remote-hd helper

From
Felipe Contreras <felipe.contreras@gmail.com>
Date
Oct 17, 2012, 18:12 UTC
Message-ID
<CAMP44s2=hhMz35SpYXMBLcQPfVaPxY4pBWZDF7zbqVwz=tbedA@mail.gmail.com>
In-Reply-To
<alpine.DEB.1.00.1210171936170.3049@bonsai2>

On Wed, Oct 17, 2012 at 7:39 PM, Johannes Schindelin <Johannes.Schindelin@gmx.de> wrote:

Show 20 quoted lines
> On Wed, 17 Oct 2012, Felipe Contreras wrote:
>
>> On Wed, Oct 17, 2012 at 6:03 PM, Johannes Schindelin
>> <Johannes.Schindelin@gmx.de> wrote:
>> > On Wed, 17 Oct 2012, Felipe Contreras wrote:
>> >
>> >> I've looked at many hg<->git tools and none satisfy me. Too
>> >> complicated, or too slow, or to difficult to setup, etc.
>> >
>> > The one I merged into Git for Windows (since that is what I install on
>> > all my machines even if they run Linux) is rock-solid. It also comes
>> > with tests. And it requires a fix I tried to get into git.git (but
>> > failed, since I was asked to do much more in addition to what I needed
>> > for myself, and I lack the time to address such requests these days).
>>
>> Maybe, but who uses it? It's quite a lot of code, and it's quite
>> difficult to setup--you would need a non-vanilla version of git.
>
> Okay, so the difficulty of setting it up is because it is not in mainline
> git.git?
My version:
1) cp contrib/remote-hg/git-remote-hg ~/bin

Your version? I don't know, but it certainly will be more than one step... may more.

Show 8 quoted lines
>> Compare this:
>> 32 files changed, 3351 insertions(+), 289 deletions(-)
>>
>> To this:
>> 1 file changed, 231 insertions(+)
>
> Yeah, and that's also because of the severe lack of tests. And the lack of
> possible code-sharing with other remote helpers.

What is there to share? It's 230 lines of code. And share it with which remote helpers? And trying to do so will certainly make it harder to setup.

As for the tests, I don't see any tests checking that the import of tags succeeds. Oh, that's right, that is not implemented, so not surprisingly; there are no tests for that. What does a dozen passing tests tell you about the code? Not much. If my code had tests, the test for importing tags would succeed, but I chose to spend my time implementing features, and trying to make them accessible to as many people as possible... rather than writing tests.

But fine, lets remove the tests out of the equation (150 lines), the number of lines of code still exceeds 3000.

Cheers.
-- 
Felipe Contreras
Previous: Johannes SchindelinNext: Sverre Rabbelier
Message 5 of 27 in “Add new git-remote-hd helper”
  1. Add new git-remote-hd helperFelipe Contreras, Oct 17, 2012
  2. Johannes SchindelinOct 17, 2012
  3. Felipe ContrerasOct 17, 2012
  4. Johannes SchindelinOct 17, 2012
  5. Felipe ContrerasOct 17, 2012
  6. Sverre RabbelierOct 17, 2012
  7. Felipe ContrerasOct 17, 2012
  8. Johannes SchindelinOct 18, 2012
  9. Felipe ContrerasOct 18, 2012
  10. Johannes SchindelinOct 18, 2012
  11. Junio C HamanoOct 18, 2012
  12. Felipe ContrerasOct 18, 2012
  13. Matthieu MoyOct 18, 2012
  14. Felipe ContrerasOct 21, 2012
  15. Johannes SchindelinOct 21, 2012
  16. Felipe ContrerasOct 21, 2012
  17. Jeff KingOct 17, 2012
  18. Felipe ContrerasOct 18, 2012
  19. Felipe ContrerasOct 18, 2012
  20. Sverre RabbelierOct 18, 2012
  21. Felipe ContrerasOct 18, 2012
  22. Johannes SchindelinOct 18, 2012
  23. Felipe ContrerasOct 18, 2012
  24. Felipe ContrerasOct 26, 2012
  25. Felipe ContrerasOct 18, 2012
  26. Michael J GruberOct 18, 2012
  27. Felipe ContrerasOct 18, 2012

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.