Re: [PATCH v3 1/5] pull: rename pull.rename to pull.mode

From: Felipe Contreras <felipe.contreras@gmail.com>
Date: Oct 12, 2013, 06:21 UTC
Message-ID: <CAMP44s1i3bxGtvMS38j3Tk5gKAZEHSKf5MBF2qJ_ReBApA1u7Q@mail.gmail.com>
In-Reply-To: <5258D2D3.9030704@bbn.com>

On Fri, Oct 11, 2013 at 11:40 PM, Richard Hansen <rhansen@bbn.com> wrote:

Show 7 quoted lines

> On 2013-10-11 22:08, Felipe Contreras wrote:
>> I'm fine with 'echo "warning: foo" >&2', but still, if you really
>> cared about consistency, there would be a warn() function
>
> So add one!  It's only one simple line:
>
>     warning() { printf %s\\n "warning: $*" >&2; }

It probably should be

warning () {
  printf 'warning: %s\n' "$*" >&2
}

But why don't _you_ do it? I have enough patches being ignored to add more to the list, specially for something I care nothing about.

> So much discussion for something so trivial...

Trivial things are what cause more discussion.

-- 
Felipe Contreras