Re: [PATCH 2/2] send-email: add series-cc-cmd option

From: Felipe Contreras <felipe.contreras@gmail.com>
Date: Nov 13, 2012, 01:01 UTC
Message-ID: <CAMP44s1gF7scb2RtZ9V9cz58y8KQuQfRk_4wsCML1JyheScP=g@mail.gmail.com>
In-Reply-To: <7vd2zigwx6.fsf@alter.siamese.dyndns.org>

On Tue, Nov 13, 2012 at 1:37 AM, Junio C Hamano <gitster@pobox.com> wrote:

Show 24 quoted lines

> Joe Perches <joe@perches.com> writes:
>
>> On Tue, 2012-11-13 at 03:21 +0530, Ramkumar Ramachandra wrote:
>>> Felipe Contreras wrote:
>>> > cc-cmd is only per-file, and many times receipients get lost without
>>> > seing the full patch series.
>>>
>>> s/seing/seeing
>>>
>>> > [...]
>>>
>>> Looks good otherwise.
>>
>> s/receipients/recipients/ too
>>
>> Practically this is ok but I think it's unnecessary.
>>
>> Output from git format-patch is always in a single
>> directory.
>
> Sorry, but I do not see how the usefulness (or necessity) of this
> new option is connected to the fact that you can tell the command to
> write the patches into a single (possibly new) directory.  Care to
> explain?

Basically 'git send-email' would do something like this: git format-patch -10 -o /tmp for x in /tmp/*; do cc_cmd $x; done

And the cc-cmd would do something like: cc_cmd() { do_stuff_with $(dirname $1)/*.patch }

-- 
Felipe Contreras