Re: [PATCH 2/2] send-email: add series-cc-cmd option

From: Felipe Contreras <felipe.contreras@gmail.com>
Date: Nov 12, 2012, 23:03 UTC
Message-ID: <CAMP44s0B42yt8eugYSjYweoX8WOXXF1f-0N-5FuUyrY5rgCiow@mail.gmail.com>
In-Reply-To: <1352760759.18715.7.camel@joe-AO722>

On Mon, Nov 12, 2012 at 11:52 PM, Joe Perches <joe@perches.com> wrote:

Show 17 quoted lines

> On Tue, 2012-11-13 at 03:21 +0530, Ramkumar Ramachandra wrote:
>> Felipe Contreras wrote:
>> > cc-cmd is only per-file, and many times receipients get lost without
>> > seing the full patch series.
>>
>> s/seing/seeing
>>
>> > [...]
>>
>> Looks good otherwise.
>
> s/receipients/recipients/ too
>
> Practically this is ok but I think it's unnecessary.
>
> Output from git format-patch is always in a single
> directory.

A temporary directory.

> My work flow is to use a script for --to and --cc
> lines that can be set to emit the same addresses for
> all files in a patch series or generate different
> addresses per patch file.

For --to-cmd and --cc-cmd? So basically you check the dirname of the argument passed?

While that works, it means you have to run the same command multiple times, one for each mail.

If the command is using something expensive such as 'git blame' and you have many patches, this is particularly bad. Also, it's not elegant :)

-- 
Felipe Contreras