[PATCH 1/2] send-email: refactor recipients_cmd()
- From
Felipe Contreras <felipe.contreras@gmail.com>
- Date
- Nov 11, 2012, 17:04 UTC
- Message-ID
- <1352653463-1923-2-git-send-email-felipe.contreras@gmail.com>
- In-Reply-To
- <1352653463-1923-1-git-send-email-felipe.contreras@gmail.com>
If we pass the full command to run, we should be able to use it in more extensible ways--see next patch.
Signed-off-by: Felipe Contreras <felipe.contreras@gmail.com> --- git-send-email.perl | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/git-send-email.perl b/git-send-email.perl index aea66a0..26d4477 100755 --- a/git-send-email.perl +++ b/git-send-email.perl @@ -1373,11 +1373,11 @@ foreach my $t (@files) { # Execute a command (e.g. $to_cmd) to get a list of email addresses # and return a results array sub recipients_cmd { - my ($prefix, $what, $cmd, $file) = @_; + my ($prefix, $what, $cmd, @args) = @_; my $sanitized_sender = sanitize_address($sender); my @addresses = (); - open my $fh, "$cmd \Q$file\E |" + open my $fh, "-|", $cmd, @args or die "($prefix) Could not execute '$cmd'"; while (my $address = <$fh>) { $address =~ s/^\s*//g;
-- 1.8.0