Re: [PATCH 0/3] Refactor useful notes functions into notes-utils.[ch]
- From
Felipe Contreras <felipe.contreras@gmail.com>
- Date
- Jun 13, 2013, 18:50 UTC
- Message-ID
- <CAMP44s1dDsRwk5q4NikA5-O86sKDQ_FQsPB2QnGZBqQZ6tpL1A@mail.gmail.com>
- In-Reply-To
- <CAMP44s3atPW-SE1yQzep-F6M13g1fPP_q2RqHKofPL0B8=JfYQ@mail.gmail.com>
On Thu, Jun 13, 2013 at 1:16 PM, Felipe Contreras <felipe.contreras@gmail.com> wrote:
> On Thu, Jun 13, 2013 at 12:24 PM, Junio C Hamano <gitster@pobox.com> wrote:
Show 6 quoted lines
>> But the thing is, that majority is what writes the majority of the >> code and does the majority of the reviews, so as maintainer I *do* >> have to give their opinion a lot of weight, not to mention my own >> opinion about how to help keep the community the most productive. > > Indeed, but that doesn't make it a fact. It remains an opinion.
And just to make it clear, I didn't deny you are the only one with commit access, and therefore you make all the shots. You made a decision, fine, I never said you can't do that.
What I said is that you should not use words to imply that your *opinion* is a fact. The fact that you make a decision doesn't make your opinion a fact, and the fact that many people share your opinion doesn't make it a fact either.
So, instead of saying:
"Just one side being right, and the other side continuing to repeat nonsense without listening."
You should say:
"Simply a matter of disagreement where the code belongs."
-- Felipe Contreras