Re: [PATCH] build: get rid of the notion of a git library
- From
Junio C Hamano <gitster@pobox.com>
- Date
- Jun 11, 2013, 17:58 UTC
- Message-ID
- <7vppvsbkc3.fsf@alter.siamese.dyndns.org>
- In-Reply-To
- <CAMP44s02PqGFNmrGEcJVT6xcQHx8k4NYqJ_TtOTUEY8XHPj0BA@mail.gmail.com>
Felipe Contreras <felipe.contreras@gmail.com> writes:
Show 5 quoted lines
>> What are the examples you have in mind, code that we want to forbid >> standalone from using? > > init_copy_notes_for_rewrite(). Nothing outside the 'git' binary would > need that. If you disagree, show me an example.
"Nothing would need that", if you are talking about the current codebase, I would agree that nothing would link to it.
But that is not a good justification for closing door to others that come later who may want to have a standalone that would want to use it. Think about rewriting filter-branch.sh in C but not as a built-in, for example.