Re: [PATCH] remote-hg: fix path when cloning with tilde expansion

From: Felipe Contreras <felipe.contreras@gmail.com>
Date: Aug 5, 2013, 20:30 UTC
Message-ID: <CAMP44s1Jqao0YvBSh18t1C2LwAF4_u2GaTNx1RwdW+pmCFcxvQ@mail.gmail.com>
In-Reply-To: <1375733541-9099-1-git-send-email-apelisse@gmail.com>

On Mon, Aug 5, 2013 at 3:12 PM, Antoine Pelisse <apelisse@gmail.com> wrote:

Show 7 quoted lines

> The current code fixes the path to make it absolute when cloning, but
> doesn't consider tilde expansion, so that scenario fails throwing an
> exception because /home/myuser/~/my/repository doesn't exists:
>
>     $ git clone hg::~/my/repository && cd repository && git fetch
>
> Fix that by using python os.path.expanduser method.

Shouldn't that be the job of the shell? (s/~/$HOME/)

-- 
Felipe Contreras