Re: [PATCH] remote-hg: fix path when cloning with tilde expansion
- From
Antoine Pelisse <apelisse@gmail.com>
- Date
- Aug 10, 2013, 15:15 UTC
- Message-ID
- <CALWbr2x6BH8oKSBt2xYWgEzrML2EqO=iEn4WTq7Lq=0U9C0C5A@mail.gmail.com>
- In-Reply-To
- <CAMP44s1NE-ac_tWej9EhMWJLRm7aq1WKOm17fZm5y_aA4ppq5g@mail.gmail.com>
On Sat, Aug 10, 2013 at 9:07 AM, Felipe Contreras <felipe.contreras@gmail.com> wrote:
Show 16 quoted lines
> On Sat, Aug 10, 2013 at 1:50 AM, Junio C Hamano <gitster@pobox.com> wrote: >> Felipe Contreras <felipe.contreras@gmail.com> writes: >> >>> If I clone ~/git, and then change my username, and move my home >>> directory, doing a 'git fetch' in ~/git wouldn't work anymore, because >>> we have expanded the path and fixed it to my old home, if instead we >>> simply return without fixing, it would still work just fine. >> >> Antoine's patch runs expanduser() only to see if the given one gets >> modified to absolute path, and makes fix_path() return without >> calling the extra 'git config', so it is my understanding that the >> above describes exactly what the patch does. Am I reading the patch >> incorrectly? > > Antoine's *second* patch, which I missed, does that, yeah. That should > work fine.
OK Cool, Thank you both,