Re: [PATCH] remote-hg: fix path when cloning with tilde expansion

From: Junio C Hamano <gitster@pobox.com>
Date: Aug 10, 2013, 06:50 UTC
Message-ID: <7v38qi2g63.fsf@alter.siamese.dyndns.org>
In-Reply-To: <CAMP44s3ULMBg6BJr6m4zkqHyD70rHSwLcuG5ph+ABr6KME8T=w@mail.gmail.com>

Felipe Contreras <felipe.contreras@gmail.com> writes:

> If I clone ~/git, and then change my username, and move my home
> directory, doing a 'git fetch' in ~/git wouldn't work anymore, because
> we have expanded the path and fixed it to my old home, if instead we
> simply return without fixing, it would still work just fine.

Antoine's patch runs expanduser() only to see if the given one gets modified to absolute path, and makes fix_path() return without calling the extra 'git config', so it is my understanding that the above describes exactly what the patch does. Am I reading the patch incorrectly?

It outsources the determination of "is this a special notation to name a home directory?" logic to .isabs(.expanduser()) instead of doing a .beginswith('~') ourselves.