Re: [PATCH 5/9] t1508 (at-combinations): document @{N} versus HEAD@{N}

From: Felipe Contreras <felipe.contreras@gmail.com>
Date: May 2, 2013, 17:27 UTC
Message-ID: <CAMP44s1Hkff1QU7undZvLfFOCeeiBrB4RRtVEOoNCsfoGZu7yg@mail.gmail.com>
In-Reply-To: <1367501974-6879-6-git-send-email-artagnon@gmail.com>

On Thu, May 2, 2013 at 8:39 AM, Ramkumar Ramachandra <artagnon@gmail.com> wrote:

Show 18 quoted lines

> All the tests so far check that @{N} is the same as HEAD@{N} (for
> positive N).  However, this is not always the case: write a couple of
> tests for this.
>
> Signed-off-by: Ramkumar Ramachandra <artagnon@gmail.com>
> ---
>  t/t1508-at-combinations.sh | 14 ++++++++++++++
>  1 file changed, 14 insertions(+)
>
> diff --git a/t/t1508-at-combinations.sh b/t/t1508-at-combinations.sh
> index eaa5337..29ffd73 100755
> --- a/t/t1508-at-combinations.sh
> +++ b/t/t1508-at-combinations.sh
> @@ -59,4 +59,18 @@ nonsense "@{1}@{u}"
>  nonsense "HEAD@{-1}"
>  nonsense "@{-1}@{-1}"
>
> +# Document differences between @{N} and HEAD@{N}.

That's enough explanation, except that we not documenting them, we are testing them.

Show 5 quoted lines

> The former resolves
> +# HEAD to a branch and looks up the logs for that branch, while the
> +# latter looks for the logs of HEAD.
> +check "HEAD@{3}" commit old-two
> +nonsense "@{3}"

Show 7 quoted lines

> +test_expect_success 'switch to old-branch' '
> +       git checkout old-branch
> +'
> +
> +check HEAD refs/heads/old-branch
> +check "HEAD@{1}" commit new-two
> +check "@{1}" commit old-one

And here we are testing something completely different.

-- 
Felipe Contreras