git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH 7/9] remote.c: teach branch_get() to treat symrefs other than HEAD

From
Ramkumar Ramachandra <artagnon@gmail.com>
Date
May 2, 2013, 15:43 UTC
Message-ID
<CALkWK0=eC2M6b5Dh9kR8TZEXRGYnYQtrpb5PUed4nDSStOCTpw@mail.gmail.com>
In-Reply-To
<CALkWK0=FbbCferG+q4qymvsm-t_rfSBRZfp7t3kO=z-EF5QYuA@mail.gmail.com>
Ramkumar Ramachandra wrote:
> So sorry about this, but this breaks some tests in t1507
> (rev-parse-upstream).  I'm looking into this now.
>
> In the meantime, reviewers can focus on the commit message.
So, it turns out that some callers expect it to read_config().

If we're still adamant about not touching branch_get(), the alternative is to call resolve_ref_unsafe() before the branch_get() call in interpret_branch_name(). We'll still retain the H@{u}, but we'll lose the 'git branch -u ram/master M'.

Previous: Ramkumar RamachandraNext: Felipe Contreras
Message 18 of 24 in “A natural solution to the @ -> HEAD problem”
  1. 0/9 A natural solution to the @ -> HEAD problemRamkumar Ramachandra, May 2, 2013
  2. 1/9 t1508 (at-combinations): simplify setupRamkumar Ramachandra, May 2, 2013
  3. 2/9 t1508 (at-combinations): test branches separatelyRamkumar Ramachandra, May 2, 2013
  4. Felipe ContrerasMay 2, 2013
  5. Ramkumar RamachandraMay 2, 2013
  6. Felipe ContrerasMay 2, 2013
  7. 3/9 t1508 (at-combinations): improve nonsense()Ramkumar Ramachandra, May 2, 2013
  8. 4/9 t1508 (at-combinations): increase coverageRamkumar Ramachandra, May 2, 2013
  9. Eric SunshineMay 2, 2013
  10. 5/9 t1508 (at-combinations): document @{N} versus HEAD@{N}Ramkumar Ramachandra, May 2, 2013
  11. Felipe ContrerasMay 2, 2013
  12. Ramkumar RamachandraMay 2, 2013
  13. Felipe ContrerasMay 2, 2013
  14. Ramkumar RamachandraMay 2, 2013
  15. 6/9 t1508 (at-combinations): test with symbolic refsRamkumar Ramachandra, May 2, 2013
  16. 7/9 remote.c: teach branch_get() to treat symrefs other than HEADRamkumar Ramachandra, May 2, 2013
  17. Ramkumar RamachandraMay 2, 2013
  18. Ramkumar RamachandraMay 2, 2013
  19. Felipe ContrerasMay 2, 2013
  20. 8/9 sha1_name.c: fix @-parsing bug in interpret_branch_name()Ramkumar Ramachandra, May 2, 2013
  21. 9/9 refs.c: make @ a pseudo-ref alias to HEADRamkumar Ramachandra, May 2, 2013
  22. Ramkumar RamachandraMay 2, 2013
  23. Felipe ContrerasMay 2, 2013
  24. Ramkumar RamachandraMay 2, 2013

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.