Re: [PATCH 1/3] blame: fix email output with mailmap

From: Felipe Contreras <felipe.contreras@gmail.com>
Date: Feb 5, 2012, 20:58 UTC
Message-ID: <CAMP44s1GntxQZ38Bz=+2Km8b9xeRyF2bTmKj6R_FgXWo3mcMoA@mail.gmail.com>
In-Reply-To: <87liohvysi.fsf@thomas.inf.ethz.ch>

On Sun, Feb 5, 2012 at 9:57 PM, Thomas Rast <trast@inf.ethz.ch> wrote:

Show 7 quoted lines

> Felipe Contreras <felipe.contreras@gmail.com> writes:
>
>> Cc: git@vger.kernel.org,  Junio C Hamano <gitster@pobox.com>,  "Brian Gianforcaro" <b.gianfo@gmail.com>,  "Marius Storm-Olsen" <marius@trolltech.com>,  "Junio C Hamano" <junkio@cox.net>
>
> I hope you noticed that Cc lists like the above really prove my point
> that you cannot automate common sense.  Your cccmd script apparently
> uses the line range in

The fact that my script is less than perfect, doesn't mean you *cannot* automate. Again, look at Linux's scripts/get_maintainer.pl. It works * perfectly* fine.

Show 8 quoted lines

>> diff --git a/builtin/blame.c b/builtin/blame.c
>> --- a/builtin/blame.c
>> +++ b/builtin/blame.c
>> @@ -1403,10 +1403,13 @@
>
> to determine who to Cc.  But in doing so, it dug up an old address for
> Junio.  It also added Brian whose only fault in all of this was fixing
> style of the 'if' you are patching.

Yes, it can be improved. But it's still better than nothing.

Show 7 quoted lines

> And on top of that it had absolutely no way of knowing that Cc'ing Peff
> would have been a good idea, seeing as you two were involved in an
> earlier discussion about this precise bug.
>
> (Granted, omitting *Peff* doesn't make that much of a difference, since
> for all I know he reads every email that crosses this list.  But my
> point still stands.)

That's not the fault of the script; that's what --cc is for.

-- 
Felipe Contreras