git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH 3/3] t: mailmap: add simple name translation test

From
Jonathan Nieder <jrnieder@gmail.com>
Date
Feb 5, 2012, 06:17 UTC
Message-ID
<20120205061738.GB1870@burratino>
In-Reply-To
<CAMP44s0Z=k6VBfv0HOGHyMBLRcPauK7K5RNvuRDbfq5=5aKVpg@mail.gmail.com>
Felipe Contreras wrote:
> You mean the commit message, you haven't made any comment about the code.

No, for this patch, more important than the absence of any explanation in the commit message (which is also important) is the code change that seems unnecessarily invasive.

You've already demonstrated that I do not have the right communication style to explain such things to you and work towards a fix that addresses both our concerns. So I give up. I'll just give my feedback on patches that concern code I care about and an explanation for the sake of others on the list that are better able to interact with you. I am willing to work with or answer questions from anyone including you, though.

Sorry, Jonathan

Previous: Felipe ContrerasNext: Felipe Contreras
Message 21 of 22 in “blame: fix output with mailmap”
  1. 0/3 blame: fix output with mailmapFelipe Contreras, Feb 4, 2012
  2. 1/3 blame: fix email output with mailmapFelipe Contreras, Feb 4, 2012
  3. Jeff KingFeb 4, 2012
  4. Thomas RastFeb 5, 2012
  5. Felipe ContrerasFeb 5, 2012
  6. Jeff KingFeb 6, 2012
  7. 2/3 t: mailmap: add 'git blame -e' testsFelipe Contreras, Feb 4, 2012
  8. Jonathan NiederFeb 4, 2012
  9. Felipe ContrerasFeb 4, 2012
  10. Jonathan NiederFeb 4, 2012
  11. Felipe ContrerasFeb 4, 2012
  12. Junio C HamanoFeb 5, 2012
  13. Felipe ContrerasFeb 5, 2012
  14. 3/3 t: mailmap: add simple name translation testFelipe Contreras, Feb 4, 2012
  15. Jonathan NiederFeb 4, 2012
  16. Felipe ContrerasFeb 4, 2012
  17. Jonathan NiederFeb 4, 2012
  18. Felipe ContrerasFeb 4, 2012
  19. Jeff KingFeb 4, 2012
  20. Felipe ContrerasFeb 6, 2012
  21. Jonathan NiederFeb 5, 2012
  22. Felipe ContrerasFeb 6, 2012

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.