Re: [PATCH 2/3] t: mailmap: add 'git blame -e' tests

From: Jonathan Nieder <jrnieder@gmail.com>
Date: Feb 4, 2012, 21:13 UTC
Message-ID: <20120204211351.GB3278@burratino>
In-Reply-To: <CAMP44s3tmiPGgAUakUgoen2aJcsKw4CygtF5f=4x2dxNTrGbGA@mail.gmail.com>

Felipe Contreras wrote:

> On Sat, Feb 4, 2012 at 10:10 PM, Jonathan Nieder <jrnieder@gmail.com> wrote:

Show 5 quoted lines

>> Since I didn't receive a copy of the cover letter or patch 1, I don't
>> know what this is intended to test _for_.  Good --- I can more easily
>> convey the reaction of future readers who do not necessarily know the
>> context in which the patch was written (and the commit message does
>> not seem to say).

[...]

> Look at the title:
> add 'git blame -e' tests
>
> s/blame/blame -e/

And? After copy/pasting this particular test with that substitution, what do we get a test for? What class of problem is it supposed to catch? I do not think a sentence or two is too much to ask for.

By the way, "I blindly copy/pasted" does not seem like a very sensible excuse for writing meaningless code (such as the "# git blame" comment line). Before the code contained one riddle. Afterwards it has two.

Hope that helps, Jonathan