Re: [PATCH v3 09/10] remote-hg: test: be a little more quiet

From: Felipe Contreras <felipe.contreras@gmail.com>
Date: May 14, 2013, 21:52 UTC
Message-ID: <CAMP44s1CYvfNw2uQrUj9DTayJc-Z9L9LLB2_4Y4KOnMBhUHxOg@mail.gmail.com>
In-Reply-To: <7vbo8dgryy.fsf@alter.siamese.dyndns.org>

On Tue, May 14, 2013 at 4:40 PM, Junio C Hamano <gitster@pobox.com> wrote:

Show 10 quoted lines

> Felipe Contreras <felipe.contreras@gmail.com> writes:
>
>> No-brainer; improve one test.
>
> In general, unless we are taking the output from commands to a file
> and grepping in it, we prefer not to have --quiet (unless you are
> testing the --quiet feature of the command, of course).  Running the
> tests without "-v" option will not show them and when running with
> "-v" to debug the tests, the extra output will help to figure out
> which step failed.

Yeah, but I spent a long time looking at the output of these tests and grew tired of all the irrelevant noise. In fact, I'm even tempted to set push.default because of that annoying message all over them. Maybe the --quiet for the push shouldn't be there, but the --quiet for checkout definitely. Either way, I don't see much value in changing this patch at this point.

-- 
Felipe Contreras